From f1976f12b687035caff02b83ee8ed3e4c62851f8 Mon Sep 17 00:00:00 2001
From: Sharon Dcruz <sharondcruz@cosq.net>
Date: Wed, 20 Aug 2025 13:37:22 +0530
Subject: [PATCH] Changes Updated for days until expiry

---
 .../membershipStatusNotifications.ts            | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/functions/src/notifications/membershipStatusNotifications.ts b/functions/src/notifications/membershipStatusNotifications.ts
index 7e1b88e..85799cf 100644
--- a/functions/src/notifications/membershipStatusNotifications.ts
+++ b/functions/src/notifications/membershipStatusNotifications.ts
@@ -465,17 +465,11 @@ async function calculateDaysUntilExpiry(
     );
 
     const now = new Date();
-    const today = new Date(now.getFullYear(), now.getMonth(), now.getDate());
-    const expiryDateOnly = new Date(
-      expiryDate.getFullYear(),
-      expiryDate.getMonth(),
-      expiryDate.getDate()
-    );
 
-    const timeDiff = expiryDateOnly.getTime() - today.getTime();
-    const daysUntilExpiry = Math.ceil(timeDiff / (1000 * 3600 * 24));
+    const timeDiff = expiryDate.getTime() - now.getTime();
+    const daysUntilExpiry = Math.floor(timeDiff / (1000 * 3600 * 24));
 
-    return daysUntilExpiry;
+    return Math.max(0, daysUntilExpiry);
   } catch (error) {
     logger.error(
       `Error calculating daysUntilExpiry for membership ${membershipId}:`,
@@ -679,7 +673,7 @@ async function sendTrainerNotifications(
       if (notificationType === "expiring") {
         const now = new Date();
         const timeDiff = expiryDate.getTime() - now.getTime();
-        daysUntilExpiry = Math.ceil(timeDiff / (1000 * 3600 * 24));
+        daysUntilExpiry = Math.floor(timeDiff / (1000 * 3600 * 24));
       }
     }
 
@@ -869,7 +863,7 @@ async function sendPlanExpiringNotification(
 
       const now = new Date();
       const timeDiff = expiryDate.getTime() - now.getTime();
-      daysUntilExpiry = Math.ceil(timeDiff / (1000 * 3600 * 24));
+      daysUntilExpiry = Math.floor(timeDiff / (1000 * 3600 * 24));
     }
 
     const existing = await app
@@ -929,7 +923,6 @@ async function sendPlanExpiringNotification(
     );
   }
 }
-
 async function getClientName(
   membershipId: string,
   clientId: string